[PATCH] powerpc: Fix warning in pci_64.c

Michael Ellerman michael at ellerman.id.au
Tue May 15 16:03:09 EST 2007


On Tue, 2007-05-15 at 14:30 +1000, Stephen Rothwell wrote:
> On Tue, 15 May 2007 14:16:35 +1000 Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
> >
> >  void pcibios_add_platform_entries(struct pci_dev *pdev)
> >  {
> > -	device_create_file(&pdev->dev, &dev_attr_devspec);
> > +	int rc = device_create_file(&pdev->dev, &dev_attr_devspec);
> > +	WARN_ON(rc != 0);
> 
> If we really don't care if the file is not created, then it is probably
> worth a comment as to why ...

Greg already has a patch from me to fix that.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20070515/17dfe665/attachment.pgp>


More information about the Linuxppc-dev mailing list