[PATCH] powerpc: Fix warning in pci_64.c

Stephen Rothwell sfr at canb.auug.org.au
Tue May 15 14:30:42 EST 2007


On Tue, 15 May 2007 14:16:35 +1000 Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
>
>  void pcibios_add_platform_entries(struct pci_dev *pdev)
>  {
> -	device_create_file(&pdev->dev, &dev_attr_devspec);
> +	int rc = device_create_file(&pdev->dev, &dev_attr_devspec);
> +	WARN_ON(rc != 0);

If we really don't care if the file is not created, then it is probably
worth a comment as to why ...

--
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20070515/41048083/attachment.pgp>


More information about the Linuxppc-dev mailing list