[PATCH v2 6/7] Holly DTS

[Josh Boyer]

On Sat, 2007-05-05 at 14:13 -0500, Olof Johansson wrote:
> > > +  	tsi109 at c0000000 {
> > > +		device_type = "tsi-bridge";
> > 
> > Don't put a "device_type" here, it is useless
> > (and undefined).  There are more like this, but
> > perhaps Linux (wrongly) probes on "device_type"
> > for those, so the kernel would need updating
> > first.
> 
> Josh is just using the precedence that the other platform gives, the
> driver is keying off of device_type. While that should be fixed, that's
> a separate issue. I'm sure they'd welcome a driver patch from you.

Right.  I'm not saying it _has_ to be device_type or anything.  It's
simply what the current in-tree functions key off of.  And if that needs
to be fixed, that's fine too.  I just don't think it's a prerequisite
for getting the Holly platform patches merged.

> 
> (Does anyone know if there's an actual firmware out there with the
> tsi-bridge device_type set, and thus just changing DTS's won't help? We'd
> still need to be able to boot/probe the device on those firmwares.)

I'm not sure.  I know PIBS doesn't _currently_ do anything with the DT
on this board, but I think work is on-going there.  As for the FSL
board, I have no idea.  Perhaps U-Boot is doing something there?

> 
> > > +		bus-frequency = <0>;
> > 
> > 0?
> 
> Filled in by bootloader/wrapper? Other dts'es are similar. Could be nice
> to have a comment next to it if that's the case.

No, it's just leftover.  It can be pulled.

josh