[PATCH v2 6/7] Holly DTS

[Olof Johansson]

On Sat, May 05, 2007 at 07:21:33PM +0200, Segher Boessenkool wrote:

> > +		PowerPC,750 at 0 {
> 
> Needs to be PowerPC,750CL etc.

Why _needs_? Apple never used anything else than PowerPC,G5, no matter
what generation chip.

> > +  	tsi109 at c0000000 {
> > +		device_type = "tsi-bridge";
> 
> Don't put a "device_type" here, it is useless
> (and undefined).  There are more like this, but
> perhaps Linux (wrongly) probes on "device_type"
> for those, so the kernel would need updating
> first.

Josh is just using the precedence that the other platform gives, the
driver is keying off of device_type. While that should be fixed, that's
a separate issue. I'm sure they'd welcome a driver patch from you.

(Does anyone know if there's an actual firmware out there with the
tsi-bridge device_type set, and thus just changing DTS's won't help? We'd
still need to be able to boot/probe the device on those firmwares.)

> > +		bus-frequency = <0>;
> 
> 0?

Filled in by bootloader/wrapper? Other dts'es are similar. Could be nice
to have a comment next to it if that's the case.


-Olof