[PATCH 05/17] bootwrapper: misc device tree fixes

David Gibson david at gibson.dropbear.id.au
Fri Mar 23 14:26:33 EST 2007


On Thu, Mar 22, 2007 at 11:22:39AM -0500, Scott Wood wrote:
> On Wed, Mar 21, 2007 at 12:51:04PM +1100, David Gibson wrote:
> > On Fri, Mar 16, 2007 at 12:28:45PM -0500, Scott Wood wrote:
> > > 1. The dtb should be generated in $tmpdir, rather than the current directory.
> > > Normally, $tmpdir is ".", so it doesn't matter, but the wrapper should obey
> > > the -W option if it should be passed.
> > 
> > This is still wrong (or at least insufficient).  If we're building
> > with a target directory different from the source directory we
> > shouldn't add anything to the source directory, but $tmpdir still
> > will.
> 
> No, it won't.  The current directory is the object directory.  I tested
> it.

Oh, ok.  Sorry, my misunderstanding.

> The tmpdir thing wasn't to fix that (since it's not broken); it was just
> something I'd noticed when I was looking over the script.
> 
> > > 2. DTC has a habit of complaining about errors which are not really
> > > errors.  Thus, the -f option is now passed to it, to force it to generate
> > > output regardless.
> > 
> > I'd really prefer not to add -f by default.  I think getting rid of
> > the bogus warnings from dtc is a better idea.
> 
> I agree, and have posted a patch to DTC do this.

Ok.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson



More information about the Linuxppc-dev mailing list