[PATCH 05/17] bootwrapper: misc device tree fixes

Scott Wood scottwood at freescale.com
Fri Mar 23 03:22:39 EST 2007


On Wed, Mar 21, 2007 at 12:51:04PM +1100, David Gibson wrote:
> On Fri, Mar 16, 2007 at 12:28:45PM -0500, Scott Wood wrote:
> > 1. The dtb should be generated in $tmpdir, rather than the current directory.
> > Normally, $tmpdir is ".", so it doesn't matter, but the wrapper should obey
> > the -W option if it should be passed.
> 
> This is still wrong (or at least insufficient).  If we're building
> with a target directory different from the source directory we
> shouldn't add anything to the source directory, but $tmpdir still
> will.

No, it won't.  The current directory is the object directory.  I tested
it.

The tmpdir thing wasn't to fix that (since it's not broken); it was just
something I'd noticed when I was looking over the script.

> > 2. DTC has a habit of complaining about errors which are not really
> > errors.  Thus, the -f option is now passed to it, to force it to generate
> > output regardless.
> 
> I'd really prefer not to add -f by default.  I think getting rid of
> the bogus warnings from dtc is a better idea.

I agree, and have posted a patch to DTC do this.

-Scott



More information about the Linuxppc-dev mailing list