[PATCH 2/8] Add uli1575 pci-bridge sector to MPC8641HPCN dts file.
Wade Farnsworth
wfarnsworth at mvista.com
Sat Jun 2 07:45:14 EST 2007
On Fri, 2007-06-01 at 20:58 +0200, Segher Boessenkool wrote:
> > + ranges = <00000000 f8000000 00100000
> > + 80000000 80000000 20000000
> > + e2000000 e2000000 00100000
> > + a0000000 a0000000 20000000
> > + e3000000 e3000000 00100000>;
> > reg = <f8000000 00100000>; // CCSRBAR 1M
>
>
> "reg" included in "ranges"? Something is wrong here.
I think it's correct for soc nodes. At least, it appears that all of
the dts files with soc nodes do similar things (including this one even
without this patch).
>
> > + pci_bridge at 0 {
>
> > + #size-cells = <2>;
> > + #address-cells = <3>;
> > + ranges = <02000000 0 80000000
> > + 02000000 0 80000000
> > + 0 20000000
> > + 01000000 0 00000000
> > + 01000000 0 00000000
> > + 0 00100000>;
> > +
> > + isa at 1e {
> > + #size-cells = <1>;
> > + #address-cells = <2>;
> >
> > + ranges = <1 0 01000000 0 0
> > + 00001000>;
>
> You map the same range (4kB legacy I/O @ 0) for both
> bridges here.
There is a one-to-one mapping between the I/O spaces of "isa" and
"pci_bridge", so wouldn't it be reasonable that a similar range be used?
>
> > + i8042 at 60 {
> > + reg = <1 60 1 1 64 1>;
>
> And this address space is included in both of those.
Again, shouldn't the child's address space be in its parent's range?
>
> > + keyboard at 0 {
> > + compatible = "pnpPNP,303";
> > + };
> > +
> > + mouse at 1 {
> > + compatible = "pnpPNP,f03";
> > + };
>
> These need a "reg" property.
I'll add them.
>
> > + rtc at 70 {
> > + compatible =
> > + "pnpPNP,b00";
> > + reg = <1 70 2>;
> > + };
> > +
> > + gpio at 400 {
> > + reg = <1 400 80>;
> > + };
>
> Inclusive again.
See above.
>
> > + i8259: i8259 at 4d0 {
>
> Needs "reg". And 4d0 isn't the primary address
> I think?
Yes, this is a standard i8259 with additional registers at 0x20 and
0xa0. I'll fix the address and add the registers.
--Wade
More information about the Linuxppc-dev
mailing list