[PATCH 2/8] Add uli1575 pci-bridge sector to MPC8641HPCN dts file.
Segher Boessenkool
segher at kernel.crashing.org
Sat Jun 2 04:58:02 EST 2007
> + ranges = <00000000 f8000000 00100000
> + 80000000 80000000 20000000
> + e2000000 e2000000 00100000
> + a0000000 a0000000 20000000
> + e3000000 e3000000 00100000>;
> reg = <f8000000 00100000>; // CCSRBAR 1M
"reg" included in "ranges"? Something is wrong here.
> + pci_bridge at 0 {
> + #size-cells = <2>;
> + #address-cells = <3>;
> + ranges = <02000000 0 80000000
> + 02000000 0 80000000
> + 0 20000000
> + 01000000 0 00000000
> + 01000000 0 00000000
> + 0 00100000>;
> +
> + isa at 1e {
> + #size-cells = <1>;
> + #address-cells = <2>;
>
> + ranges = <1 0 01000000 0 0
> + 00001000>;
You map the same range (4kB legacy I/O @ 0) for both
bridges here.
> + i8042 at 60 {
> + reg = <1 60 1 1 64 1>;
And this address space is included in both of those.
> + keyboard at 0 {
> + compatible = "pnpPNP,303";
> + };
> +
> + mouse at 1 {
> + compatible = "pnpPNP,f03";
> + };
These need a "reg" property.
> + rtc at 70 {
> + compatible =
> + "pnpPNP,b00";
> + reg = <1 70 2>;
> + };
> +
> + gpio at 400 {
> + reg = <1 400 80>;
> + };
Inclusive again.
> + i8259: i8259 at 4d0 {
Needs "reg". And 4d0 isn't the primary address
I think?
Segher
More information about the Linuxppc-dev
mailing list