[PATCH 11/19] powerpc: setup usb host controller in SCC for Celleb
Ishizaki Kou
kou.ishizaki at toshiba.co.jp
Thu Jan 18 23:08:28 EST 2007
Ben-san,
Thank you for your suggestion.
> On Fri, 2007-01-12 at 10:11 +0900, Ishizaki Kou wrote:
> > USB host controller in SCC requires enable sequence. It should be done
> > before USB host drivers start.
> >
> > Signed-off-by: Kou Ishizaki <kou.ishizaki at toshiba.co.jp>
>
> Just a small nit here: Either you want that code to kick on any platform
> that has a Toshiba SCC with that controller, in which case, put it in a
> more generic place, like arch/powerpc/kernel/pci_64.c or
> drivers/usb/host/pci_quirk.c, or you want that to run only on celleb (at
> least for now) in which case, add a
>
> if (!machine_is(celleb))
> return;
>
> At the beginning, since if one builds a kernel with more than one
> platform in, your quirk will be run regardless of the platform selected
> at boot.
>
> Ben.
Because it depends on platform, we will add platform check code.
Best regards,
Kou Ishizaki
More information about the Linuxppc-dev
mailing list