[patch][5/5] powerpc V2: Add the general support for Embedded Floating-Point instructions

Kumar Gala galak at kernel.crashing.org
Fri Feb 23 05:22:39 EST 2007


On Feb 22, 2007, at 10:56 AM, Sergei Shtylyov wrote:

> Hello.
>
> Segher Boessenkool wrote:
>>>>>  arch/powerpc/sysdev/sigfpe_handler.c |  361
>>>>> ++++++++++++++++++++++++++++++++++
>
>>>>    I'm sorry, but is sysdev/ really fitting place for this file?
>>>> Shouldn't it be under kernel/ or math-emu/ instead?
>
>>>     Also, the name doesn't look fittingto me, since we're not  
>>> handling
>>> *SIGFPE* here (which is for userland), we're handling SPE  
>>> exceptions.
>
>> arch/powerpc/math-emu/spe/<whatever>.c seems like a good
>> place?
>
>     Yeah, certainly more like it. :-)
>
>> Segher

Agreed, this shouldn't have been in sysdev, didn't notice that :)

We should probably rename this as well, since its not just handling  
the sigfpe part, but the actual fixup/emulation.

- k



More information about the Linuxppc-dev mailing list