[PATCH 1/3] add USB setup code for 8349emds PB

Li Yang-r58472 LeoLi at freescale.com
Tue Feb 6 15:52:46 EST 2007


> >>>>> diff --git a/arch/powerpc/platforms/83xx/Kconfig b/arch/powerpc/
> >>>>> platforms/83xx/Kconfig
> >>>>> index edcd5b8..5371645 100644
> >>>>> --- a/arch/powerpc/platforms/83xx/Kconfig
> >>>>> +++ b/arch/powerpc/platforms/83xx/Kconfig
> >>>>> @@ -59,4 +59,8 @@ config PPC_MPC836x
> >>>>> 	select PPC_INDIRECT_PCI
> >>>>> 	default y if MPC8360E_PB
> >>>>> +config 834x_USB_SUPPORT
> >>>>> +	bool
> >>>>> +	default y if MPC834x_SYS && (USB || USB_GADGET)
> >>>>> +
> >>>>
> >>>> Do we really need to introduce a new config option?
> >>>
> >>> It will be neater to make use of the Kconfig feature than judging
> > all
> >>> the macros and module variations.  It will be a very long #if
> > defined
> >>> the other way.
> >>
> >> Huh, it would look like:
> >>
> >> #if defined(CONFIG_USB) || defined(CONFIG_USB_GADGET).
> >
> > Are you sure we don't need CONFIG_USB_MODULE and
> > CONFIG_USB_GADGET_MODULE any more?  At least in some early kernel
> > version, they are needed explicitly.
> 
> I'm not seeing any references to either CONFIG option.
> 
> Also, I'm not seeing any code to support OTG for ehci/83xx... (in the
> kernel tree).  Are there patches for this?

The complete OTG protocol support is not submitted yet, but the OTG mode
support for ehci-fsl is submitted to linux-usb.

- Leo



More information about the Linuxppc-dev mailing list