[PATCH 1/3] add USB setup code for 8349emds PB

[Kumar Gala]

On Feb 5, 2007, at 9:46 PM, Li Yang-r58472 wrote:

>> -----Original Message-----
>> From: Kumar Gala [mailto:galak at kernel.crashing.org]
>> Sent: Tuesday, February 06, 2007 11:31 AM
>> To: Li Yang-r58472
>> Cc: Paul; linuxppc-dev at ozlabs.org
>> Subject: Re: [PATCH 1/3] add USB setup code for 8349emds PB
>>
>>
>> On Feb 5, 2007, at 9:15 PM, Li Yang-r58472 wrote:
>>
>>>> -----Original Message-----
>>>> From: Kumar Gala [mailto:galak at kernel.crashing.org]
>>>> Sent: Monday, February 05, 2007 11:04 PM
>>>> To: Li Yang-r58472
>>>> Cc: Paul; linuxppc-dev at ozlabs.org
>>>> Subject: Re: [PATCH 1/3] add USB setup code for 8349emds PB
>>>>
>>>>
>>>> On Feb 5, 2007, at 3:09 AM, Li Yang wrote:
>>>>
>>>> You have no description about what this patch does and why its
>>>> needed.
>>>
>>> Add cpu and board specific initialization code for USB to work in
> both
>>> MPH and DR mode for MPC8349EMDS PB board.
>>>>
>>>>> Signed-off-by: Li Yang <leoli at freescale.com>
>>>>> ---
>>>>> arch/powerpc/platforms/83xx/Kconfig       |    4 ++
>>>>> arch/powerpc/platforms/83xx/mpc834x_sys.c |   77
> +++++++++++++++++++
>>>>> ++++++++++
>>>>> arch/powerpc/platforms/83xx/mpc834x_sys.h |   23 +++++++++
>>>>> 3 files changed, 104 insertions(+), 0 deletions(-)
>>>>>
>>>>> diff --git a/arch/powerpc/platforms/83xx/Kconfig b/arch/powerpc/
>>>>> platforms/83xx/Kconfig
>>>>> index edcd5b8..5371645 100644
>>>>> --- a/arch/powerpc/platforms/83xx/Kconfig
>>>>> +++ b/arch/powerpc/platforms/83xx/Kconfig
>>>>> @@ -59,4 +59,8 @@ config PPC_MPC836x
>>>>> 	select PPC_INDIRECT_PCI
>>>>> 	default y if MPC8360E_PB
>>>>> +config 834x_USB_SUPPORT
>>>>> +	bool
>>>>> +	default y if MPC834x_SYS && (USB || USB_GADGET)
>>>>> +
>>>>
>>>> Do we really need to introduce a new config option?
>>>
>>> It will be neater to make use of the Kconfig feature than judging
> all
>>> the macros and module variations.  It will be a very long #if
> defined
>>> the other way.
>>
>> Huh, it would look like:
>>
>> #if defined(CONFIG_USB) || defined(CONFIG_USB_GADGET).
>
> Are you sure we don't need CONFIG_USB_MODULE and
> CONFIG_USB_GADGET_MODULE any more?  At least in some early kernel
> version, they are needed explicitly.

I'm not seeing any references to either CONFIG option.

Also, I'm not seeing any code to support OTG for ehci/83xx... (in the  
kernel tree).  Are there patches for this?

- k