[PATCH v2 3/4] USB: add Cypress c67x00 OTG controller HCD driver

[Stephen Rothwell]

Hi Grant,

Just did a superficial look over this.

On Fri, 28 Dec 2007 16:52:41 -0700 Grant Likely <grant.likely at secretlab.ca> wrote:
>
> +++ b/drivers/usb/c67x00/c67x00-hcd.c
> +
> +#define OK(x)			len = (x); break

I was going to say "URK!" but it looks like it is not used, so just
remove it.

> +static int c67x00_hub_status_data(struct usb_hcd *hcd, char *buf)
> +{
> +	struct c67x00_hcd *c67x00 = hcd_to_c67x00_hcd(hcd);
> +	struct c67x00_sie *sie = c67x00->sie;
> +	u16 status;
> +	int i;
> +
> +	*buf = 0;
> +	status = c67x00_ll_husb_get_status(sie);
> +	for (i=0; i<C67X00_PORTS; i++)

Spacing.

> +static int c67x00_hcd_get_frame(struct usb_hcd *hcd)
> +{
> +	struct c67x00_hcd *c67x00 = hcd_to_c67x00_hcd(hcd);
> +	u16 temp_val;
> +	dev_dbg(c67x00_hcd_dev(c67x00), "%s\n", __FUNCTION__);

We normally put a blank line between declarations and code.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20071229/c1fb4557/attachment.pgp>