[PATCH v2 2/4] USB: add Cypress c67x00 OTG controller core driver

Stephen Rothwell sfr at canb.auug.org.au
Sat Dec 29 17:24:26 EST 2007


Hi Grant,

Just one nit ...

On Fri, 28 Dec 2007 16:52:36 -0700 Grant Likely <grant.likely at secretlab.ca> wrote:
>
> +static int __devinit c67x00_drv_probe(struct platform_device *pdev)
> +{
> +	struct c67x00_device *c67x00;
> +	struct c67x00_platform_data *pdata;
> +	struct resource *res, *res2;
> +	int ret, i;
> +
> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!res)
> +		return -ENODEV;
> +
> +	res2 = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> +	if (!res2)
> +		return -ENODEV;
> +
> +	pdata = (struct c67x00_platform_data*)pdev->dev.platform_data;

This cast is unnecessary.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20071229/fd0f728a/attachment.pgp>


More information about the Linuxppc-dev mailing list