[PATCH v2] powerpc: Do not fail build if mkimage is not available

Wolfgang Denk wd at denx.de
Thu Dec 27 21:14:04 EST 2007


In message <200712261708.51432.mb at bu3sch.de> you wrote:
> On Wednesday 26 December 2007 17:03:43 Andreas Schwab wrote:
> > Michael Buesch <mb at bu3sch.de> writes:
> > 
> > > +    set +e
> > >      mkimage -A ppc -O linux -T kernel -C gzip -a 00000000 -e 00000000 \
> > >  	$uboot_version -d "$vmz" "$ofile"
> > > +    [ $? -eq 0 ] || exit 0
> > > +    set -e
> > 
> > mkimage ... || exit 0
> 
> Could you PLEASE increase your verbosity?
> Why is mkimage || exit 0 any better than my test?

Because it works, while your's doesn't.

Make runs each command in a new shell. Your "set +e" is in vain,  and
so is your test of the return code.

Um... doesn't make throw  an  error  anyway  when  the  execution  of
mkimage fails?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Success in marriage is not so much finding the right person as it  is
being the right person.



More information about the Linuxppc-dev mailing list