[PATCH/RFC] powerpc: DBox2 Board Support

[Stephen Rothwell]

On Sat, 22 Dec 2007 20:13:31 +0100 Jochen Friedrich <jochen at scram.de> wrote:
>
> +++ b/arch/powerpc/platforms/8xx/dbox2.h
> +
> +#include <sysdev/fsl_soc.h>

Nothing in this header files uses anything in that one, so don't include
it.

> +++ b/arch/powerpc/platforms/8xx/dbox2_setup.c
> +
> +char *dbox2_manuf_name[3] = {

static const.

> +	"Nokia",
> +	"Philips",
> +	"Sagem",
> +};
> +
> +static enum dbox2_mid dbox2_manuf_id;
> +
> +struct cpm_pin {
> +	int port, pin, flags;
> +};
> +
> +static struct cpm_pin dbox2_pins[] = {

const?

> +static int __init dbox2_probe(void)
> +{
> +	unsigned long root = of_get_flat_dt_root();
> +	return of_flat_dt_is_compatible(root, "betaresearch,dbox2");

You should include asm/prom.h to use the flattened device tree function.

> +static struct of_device_id __initdata of_bus_ids[] = {

__initdata

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20071223/9a260e84/attachment.pgp>