[PATCH v3 4/4] Freescale enhanced Local Bus Controller FCM NAND support.

Nathan Lynch ntl at pobox.com
Sat Dec 15 12:23:21 EST 2007


Josh Boyer wrote:
> On Fri, 14 Dec 2007 16:17:36 -0600
> Scott Wood <scottwood at freescale.com> wrote:
>
> > +	child = NULL;
> > +	while ((child = of_get_next_child(ofdev->node, child)))
> > +		if (of_device_is_compatible(child, "fsl,elbc-fcm-nand"))
> > +			fsl_elbc_chip_probe(ctrl, child);
> 
> Don't you need some of_node_put calls here?

The of_... iterators do of_node_put() for you as long as you don't
break out of the loop early.




More information about the Linuxppc-dev mailing list