[PATCH 2/2] powerpc: Add IPIC MSI support

[Jin Zhengxiong]

> -----Original Message-----
> From: Kumar Gala [mailto:galak at kernel.crashing.org] 
> Sent: Friday, December 14, 2007 4:52 PM
> To: Li Tony
> Cc: Phillips Kim; michael at ellerman.id.au; linuxppc-dev list; 
> Jin Zhengxiong; Olof Johansson
> Subject: Re: [PATCH 2/2] powerpc: Add IPIC MSI support
> 
> 
> On Dec 14, 2007, at 2:47 AM, Li Tony wrote:
> 
> >
> > Hi,
> >
> > I think it is possible to make common code to support both IPIC and 
> > MPIC.
> > Currently, the MPIC has already implemented MSI which is different 
> > from IPIC and embedded into the mpic code body.
> > If want to unifiy MSI code, we need to remove the current MPIC MSI 
> > implementation.
> 
> The MPIC is going to have to support several MSI styles 
> (IBM/U3, PaSemi, and FSL) since we all seem to handle it differently.

I enabled the MSI interrrupts on 85xx/86xx board similar to the IBM/U3 board.
Did not enable another host as on 83xx board. Put the 256 MSI interrupts after the 
256 system interrupts and use the same mpic host. This can work and can reuse most
of the mpic_msi codes. but since the host_map of MSI is something different with MPIC.
I also think it's good idea to make a 2 level PIC handling mechanism for MSI on 85xx/86xx board and 
common the code to support for both IPIC and MPIC for fsl board.

 
> > Micheal, what is your opinion ??
> >
> > Jin is working on 86xx msi now.
> 
> What PCIe cards are you using to test MSIs?

I used a SysKonnect 1000M PCIe ether card and the SATA driver to test the MSI on 85xx/86xx board.

Best Regards,
Jason

> - k
> 
> >> -----Original Message-----
> >> From: Kumar Gala [mailto:galak at kernel.crashing.org]
> >> Sent: 2007年12月14日 13:45
> >> To: Li Tony
> >> Cc: Phillips Kim; michael at ellerman.id.au; linuxppc-dev
> >> Subject: Re: [PATCH 2/2] powerpc: Add IPIC MSI support
> >>
> >>
> >> On Dec 4, 2007, at 4:39 AM, Li Li wrote:
> >>
> >>> Modified based on discussion on list.
> >>>
> >>> 1. Adopt virq_to_hw routine
> >>> 2. Correct a legacy bug
> >>>
> >>> Implements the IPIC MSI as two level interrupt controller.
> >>>
> >>> Signed-off-by: Tony Li <tony.li at freescale.com>
> >>
> >> Tony, have you looked at the 85xx/86xx PCIe MSI mechanism?
> >> The 2nd level PIC handling seems like its pretty similar 
> between IPIC 
> >> and MPIC.  Would like to see if we could somehow make the 
> code common 
> >> for to handle MSIs from both?
> >>
> >> - k
> >>
> 
>