[PATCH 2/3] mpc82xx: Embedded Planet EP8248E support

[Stephen Rothwell]

On Wed, 12 Dec 2007 16:48:24 -0600 Scott Wood <scottwood at freescale.com> wrote:
>
> Stephen Rothwell wrote:
> >> +	ep8248e_bcsr = of_iomap(ep8248e_bcsr_node, 0);
> > 
> > of_node_put(ep8248e_bcsr_node;
> 
> No, because we hold on to the node for later use in ep8248e_mdio_probe().

Sorry, you are right, I didn't notice that it was global ...

> BTW, is there any actual node removal done that justifies dealing with 
> refcounts everywhere?

In the hotplug code.  So I guess it is not very relevant to you, but it
is a pain to retrofit this stuff if it does become important more widely.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20071213/13519623/attachment.pgp>