[PATCH 1/5] PowerPC 74xx: Katana Qp device tree

[Dale Farnsworth]

David Gibson wrote:
> On Thu, Nov 29, 2007 at 06:28:36PM +0300, Andrei Dolnikov wrote:
> > Device tree source file for the Emerson Katana Qp board

[snip]

> > +	mv64x60 at f8100000 { /* Marvell Discovery */
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		model = "mv64460";			/* Default */
> > +		compatible = "marvell,mv64x60";

[snip]

> > +		mdio {
> 
> There must be some way of actuall accessing the mdio bus, so this node
> ought to have a 'reg' property and unit address.

There is no way for the cpu to directly access the mdio bus.  The
mdio bus is internally accessed by the ethernet MAC.  That being the
case, maybe it makes more sense to move the mdio node inside of the
multiethernet node, as follows, but I don't see how we can give it
a reg property or a unit address.

		multiethernet at 2000 {
			reg = <0x2000 0x2000>;
			ethernet at 0 {
				device_type = "network";
				compatible = "marvell,mv64360-eth";
				reg = <0>;
				interrupts = <32>;
				interrupt-parent = <&PIC>;
				phy = <&PHY0>;
				local-mac-address = [ 00 00 00 00 00 00 ];
			};
			ethernet at 1 {
				device_type = "network";
				compatible = "marvell,mv64360-eth";
				reg = <1>;
				interrupts = <33>;
				interrupt-parent = <&PIC>;
				phy = <&PHY1>;
				local-mac-address = [ 00 00 00 00 00 00 ];
			};
			mdio {
				#address-cells = <1>;
				#size-cells = <0>;
				device_type = "mdio";
				compatible = "marvell,mv64360-mdio";
				PHY0: ethernet-phy at 1 {
					device_type = "ethernet-phy";
					compatible = "broadcom,bcm5421";
					interrupts = <76>;	/* GPP 12 */
					interrupt-parent = <&PIC>;
					reg = <1>;
				};
				PHY1: ethernet-phy at 3 {
					device_type = "ethernet-phy";
					compatible = "broadcom,bcm5421";
					interrupts = <76>;	/* GPP 12 */
					interrupt-parent = <&PIC>;
					reg = <3>;
				};
			};
		};

Look OK?

-Dale