[PATCH 21/25] powerpc: Adds decoding of 440SPE memory size to boot wrapper library

Benjamin Herrenschmidt benh at kernel.crashing.org
Sun Dec 9 18:04:48 EST 2007


On Thu, 2007-12-06 at 21:22 -0600, Josh Boyer wrote:
> On Thu, 06 Dec 2007 19:00:20 +1100
> Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
> 
> > This adds a function to the bootwrapper 4xx library to decode memory
> > size on 440SPE processors.
> 
> Why did you rename the fixup_memsize function?  Could you add that to
> the changelog, and perhaps a bit about adding the SDRAM0_{READ,WRITE}
> macros

Because there's 3 fixup_*_memsize functions, felt it would be better
that they all have distinctive names no ? I don't see the need of
altering the changelog tho... If you don't know what those macros stand
for you probably should stay clear from those registers anyway.

Ben.




More information about the Linuxppc-dev mailing list