[PATCH] ipic: change ack operation that register is accessedonly when needed

Benjamin Herrenschmidt benh at kernel.crashing.org
Tue Dec 4 13:15:56 EST 2007


On Tue, 2007-12-04 at 10:06 +0800, Li Yang wrote:
> > That should be handled by the higher level flow handler. The 
> > generic edge one calls ack and the level one mask_and_ack. 
> > Just make them do the right thing, no need to test for the 
> > flow type in the low level function.
> 
> But actually ack is called by edge and per cpu handlers.  Mask_and_ack
> is also called by edge handler when the same interrupt is already in
> progress.  So I don't think that ack/mask_and_ack implicates flow type
> by design.

They do and you can pass different irq_chip with different mask/ack
routines if necessary.

Ben.





More information about the Linuxppc-dev mailing list