[PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

Olof Johansson olof at lixom.net
Sun Dec 2 14:59:09 EST 2007


On Tue, Nov 27, 2007 at 06:39:08PM +0300, Anton Vorontsov wrote:

> +static struct of_device_id pata_of_platform_match[] = {
> +	{ .compatible = "pata-platform", },
> +};

On top of previous comment about the compatible string being
inappropriate:

You should add a MODULE_DEVICE_TABLE() entry for this. Dave Woodhouse
pointed out it's needed for autoloading modules (i.e. by the fedora
installer, etc).


-Olof




More information about the Linuxppc-dev mailing list