Document and implement an improved flash device binding
David Gibson
dwg at au1.ibm.com
Thu Aug 30 11:18:04 EST 2007
On Wed, Aug 29, 2007 at 10:43:41AM +0200, Domen Puncer wrote:
> On 29/08/07 16:13 +1000, David Gibson wrote:
>
> <snip>
> > static int __devinit of_physmap_probe(struct of_device *dev, const struct of_device_id *match)
> > {
> > struct device_node *dp = dev->node;
> > struct resource res;
> > struct physmap_flash_info *info;
> > - const char **probe_type;
> > - const char *of_probe;
> > + const char *probe_type = (const char *)match->data;
> > const u32 *width;
> > int err;
> >
> > + dev_warn(&dev->dev, "Device tree uses obsolete \"direct-mapped\" "
> > + "flash binding\n");
>
> This is printed for new binding too :-)
Duh, put that warning in completely the wrong place. I was awake,
obviously :-/
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
More information about the Linuxppc-dev
mailing list