Document and implement an improved flash device binding

Domen Puncer domen.puncer at telargo.com
Wed Aug 29 18:43:41 EST 2007


On 29/08/07 16:13 +1000, David Gibson wrote:

<snip>
>  static int __devinit of_physmap_probe(struct of_device *dev, const struct of_device_id *match)
>  {
>  	struct device_node *dp = dev->node;
>  	struct resource res;
>  	struct physmap_flash_info *info;
> -	const char **probe_type;
> -	const char *of_probe;
> +	const char *probe_type = (const char *)match->data;
>  	const u32 *width;
>  	int err;
>  
> +	dev_warn(&dev->dev, "Device tree uses obsolete \"direct-mapped\" "
> +		 "flash binding\n");

This is printed for new binding too :-)

Other than this, it works fine for me.


	Domen



More information about the Linuxppc-dev mailing list