[PATCH 3/6] Consolidate of_find_property

Paul Mackerras paulus at samba.org
Wed Apr 25 11:43:41 EST 2007


Segher Boessenkool writes:

> Property names aren't supposed to contain uppercase
> characters. 

Somebody forgot to tell Apple:

$ ls /proc/device-tree/ht at 0,f2000000/pci at 9/ata-6 at d
total 23
1 #address-cells             1 cable-type    1 interrupt-parent  1 name
1 #size-cells                1 class-code    1 interrupts        1 reg
1 AAPL,bus-id                1 compatible    0 lba-48            1 revision-id
1 AAPL,connector             1 device-id     1 linux,phandle     1 vendor-id
1 AAPL,pio-timing            1 device_type   1 max-latency
1 AAPL,requested-priorities  1 devsel-speed  1 min-grant
1 assigned-addresses         0 disk/         1 model

> I can swing both ways on which of strcmp()
> or strcasecmp() is better, but there seems no reason
> to do this differently on each platform.

The question is, what ppc drivers would break if we used strcmp
instead of strcasecmp?  I have a dim memory that some Apple machines
had "ata" and others had "ATA" for the hard disk, for instance.

Paul.



More information about the Linuxppc-dev mailing list