[PATCH 3/6] Consolidate of_find_property

Segher Boessenkool segher at kernel.crashing.org
Tue Apr 24 23:41:59 EST 2007


> Also, Sparc uses strcasecmp to compare property names while PowerPC
> uses strcmp.

Property names aren't supposed to contain uppercase
characters.  I can swing both ways on which of strcmp()
or strcasecmp() is better, but there seems no reason
to do this differently on each platform.

Let me repeat this isn't an argument against your
patch -- indeed, it is probably better to keep the
status quo as the first merging step; I'm just
pointing out stuff that should be fixed in some
follow up.


Segher




More information about the Linuxppc-dev mailing list