[PATCH dtc take 2] Fix reserve map output for asm format.

Milton Miller miltonm at bga.com
Mon Apr 16 05:59:44 EST 2007

Sometime around Sun Apr 15 12:29:14 EST 2007, Jerry Van Baren wrote:
> Add extra reserve map slots output for asm format (previously done for 
> dtb
>   output).
> Signed-off-by: Gerald Van Baren <vanbaren at cideas.com>
> ---
> Hi Jon, David,
> Here is a patch that fixes the asm output without the (unnecessary)
> calloc change.
> Best regards,
> gvb

The previous description had
> Use cmalloc to pre-zero memory (for dtb input) and handle dtb (binary)
>   input being shorter than the total blob length (result of putting
>   extra space in the blob).

Which at least said in the description the unrelated things it was 

>         while (sizeleft) {
> -               if (feof(f))
> -                       die("EOF before reading %d bytes of DT blob\n",
> -                           totalsize);
> +               if (feof(f)) {
> +                       WARNMSG("EOF after reading %d of %d bytes of 
> DT blob, assuming there is extra space in the blob.\n",
> +                           totalsize - sizeleft, totalsize);
> +                       break;
> +               }

I thnk the above should be an ERROR and cause failure without
the -f (force) option.

The total_size says how much data should be copied.  Anything
less and there is data missing.   Assuming zeros is wrong for
most sections (the exception being the memory reserve list
that had a terminating 0 entry within the read portion).


More information about the Linuxppc-dev mailing list