[PATCH] powerpc: Fix PowerPC 750CL CPU features

Josh Boyer jwboyer at linux.vnet.ibm.com
Fri Apr 13 03:11:46 EST 2007


On Thu, 2007-04-12 at 12:06 -0500, Kumar Gala wrote:
> On Apr 12, 2007, at 11:41 AM, Segher Boessenkool wrote:
> 
> >> PowerPC 750CL has high BATs.  The patch below sets cpu_features to
> >> match that.
> >> Without it, the original firmware mappings in the high BATs aren't
> >> cleared
> >> which can cause "odd" address translations to occur.
> >
> >> -		.cpu_features		= CPU_FTRS_750,
> >> +		.cpu_features		= CPU_FTRS_750GX,
> >
> > The difference between these two is
> >
> > #define CPU_FTRS_750GX  (CPU_FTR_DUAL_PLL_750FX |  
> > CPU_FTR_HAS_HIGH_BATS)
> > #define CPU_FTRS_750    (CPU_FTR_COMMON)
> >
> > 750GX excludes COMMON, which seems like a bug.  With
> > your change, 750CL uses DUAL_PLL_750FX; does it actually
> > have that feature?
> 
> I agree the 750GX should include COMMON, we probably don't notice  
> since its never in a SMP system.

I'll send a separate patch to fix that.

josh




More information about the Linuxppc-dev mailing list