[PATCH] powerpc: Fix PowerPC 750CL CPU features

Kumar Gala galak at kernel.crashing.org
Fri Apr 13 03:06:02 EST 2007


On Apr 12, 2007, at 11:41 AM, Segher Boessenkool wrote:

>> PowerPC 750CL has high BATs.  The patch below sets cpu_features to
>> match that.
>> Without it, the original firmware mappings in the high BATs aren't
>> cleared
>> which can cause "odd" address translations to occur.
>
>> -		.cpu_features		= CPU_FTRS_750,
>> +		.cpu_features		= CPU_FTRS_750GX,
>
> The difference between these two is
>
> #define CPU_FTRS_750GX  (CPU_FTR_DUAL_PLL_750FX |  
> CPU_FTR_HAS_HIGH_BATS)
> #define CPU_FTRS_750    (CPU_FTR_COMMON)
>
> 750GX excludes COMMON, which seems like a bug.  With
> your change, 750CL uses DUAL_PLL_750FX; does it actually
> have that feature?

I agree the 750GX should include COMMON, we probably don't notice  
since its never in a SMP system.

- k





More information about the Linuxppc-dev mailing list