[POWERPC] merge iSeries i/o operations with the rest

[Stephen Rothwell]

Hi Hollis,

On Wed, 20 Sep 2006 11:01:36 -0500 Hollis Blanchard <hollisb at us.ibm.com> wrote:
>
> On Wed, 2006-09-20 at 22:15 +1000, Stephen Rothwell wrote:
> > +       if (firmware_has_feature(FW_FEATURE_ISERIES)) {
> > +               BUG();
> > +               return;
> > +       }
> 
> Shouldn't all these be BUG_ON(firmware_has_feature(FW_FEATURE_ISERIES))?

In this case, the return helps because the compiler will not generate the
following code in iSeries only builds.  If we could tell the compiler
that BUG() and BUG_ON() won't return, then BUG_ON() would be better.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/