On Wed, 2006-09-20 at 22:15 +1000, Stephen Rothwell wrote: > + if (firmware_has_feature(FW_FEATURE_ISERIES)) { > + BUG(); > + return; > + } Shouldn't all these be BUG_ON(firmware_has_feature(FW_FEATURE_ISERIES))? -- Hollis Blanchard IBM Linux Technology Center