[PATCH 1/2] Add MPC52xx Interrupt controller support for ARCH=powerpc
benh at kernel.crashing.org
Tue Oct 31 18:38:55 EST 2006
> Well, on a personal point of view, the only usable mailer I know does
> not run on my 'work' OS. I'll copy/paste from an editor ;-)
And both are ? (mailer and 'work' OS ? :)
> > +/* MBAR position */
> > +#define MPC52xx_MBAR 0xf0000000 /* Phys address */
> > +#define MPC52xx_MBAR_VIRT 0xf0000000 /* Virt address */
> > +#define MPC52xx_MBAR_SIZE 0x00010000
> > +
> > +#define MPC52xx_PA(x) ((phys_addr_t)(MPC52xx_MBAR + (x)))
> > +#define MPC52xx_VA(x) ((void __iomem *)(MPC52xx_MBAR_VIRT + (x)))
> > This should be handled dynamically (pulled from the device tree), I
> > doubt MBAR will be at the same location for all boards.
> Well, 0xf000000 seems some kind of 'standart' value. we could have a
> global variable 'mpc52xx_mbar' which would be default 0xf0000000 and
> modified by each platform.
No. No magic globals. If we need some common code for dealing with some
52xx specific bits, them have a file somewhere, possibly in sysdev,
containing those and exposing functions.
> > * can you split out the interrupt controller header info into a
> > mpc52xx_pic.h [mpc52xx_intr, MPC52xx_IRQ_...]
> Well, I dod personally have the whole structure/define in a single
> header rather than splitting in xxx files.
More information about the Linuxppc-dev