[PATCH] General CHRP/MPC5K2 Platform and drivers support - to comment
galak at kernel.crashing.org
Fri Oct 20 16:06:14 EST 2006
On Oct 19, 2006, at 7:39 AM, Nicolas DET wrote:
> This 'big' patch adds support for CHRP/MPC52xx based platform.
> Here, this is the bPlan's Efika computer (http://www.bplan-gmbh.de/
> We know this patch is not totaly compliant with Documentation/
> We would like people to comment and review it. This way we would
> provide a new patch with the changes required (if any) for an
> upcomming merge in the kernel.
> This patch has been applied on the kernel 126.96.36.199.
> Signed-off-by: Nicolas DET <nd at bplan-gmbh.de>
> Signed-off-by: Sven Luther <sl at bplan-gmbh.de>
I think it would be extremely useful to get a dump of what the device-
tree looks like. We have to be very careful to device nodes for 52xx
components are competed consistent between this 'CHRP' style and a
more embedded 52xx boards.
Some high level comments:
1. lets stick with the 52xx naming, instead of 5k2
2. PIC code needs to be updated for new interrupt model (as well as
remove of pt_regs)
3. use standard kernel debug macros
4. look at replacing sram_allocator w/rheap
if you repost the patch broken up into driver and platform bits it
will be easier to provide more detailed comments.
More information about the Linuxppc-dev