[PATCH 7/16] powerpc: add support for ps3 platform
Geoff Levand
geoffrey.levand at am.sony.com
Fri Nov 17 12:33:21 EST 2006
Benjamin Herrenschmidt wrote:
>> > +
>> > +enum page_size {
>> > + page_size_4k = 12U,
>> > + page_size_64k = 16U,
>> > + page_size_16m = 24U,
>> > +};
>>
>> Please use ALL_CAPS for such constants.
>
> And call them PAGE_SHIFT_* while at it :-)
The HV docs call this page size, so that is what I used for
the symbol. I'll look at the usage again and reconsider.
-Geoff
More information about the Linuxppc-dev
mailing list