[PATCH 7/16] powerpc: add support for ps3 platform

Benjamin Herrenschmidt benh at kernel.crashing.org
Fri Nov 17 11:39:44 EST 2006


> > +
> > +enum page_size {
> > +	page_size_4k = 12U,
> > +	page_size_64k = 16U,
> > +	page_size_16m = 24U,
> > +};
> 
> Please use ALL_CAPS for such constants.

And call them PAGE_SHIFT_* while at it :-)

Ben.





More information about the Linuxppc-dev mailing list