> > + > > +enum page_size { > > + page_size_4k = 12U, > > + page_size_64k = 16U, > > + page_size_16m = 24U, > > +}; > > Please use ALL_CAPS for such constants. And call them PAGE_SHIFT_* while at it :-) Ben.