[PATCH/RFC] Hookable IO operations #2
Segher Boessenkool
segher at kernel.crashing.org
Sun Nov 5 09:50:02 EST 2006
Much nicer, great. I said I'd comment though, so some
trivial nits :-)
> + * * __ioremap_explicit (and it's pending __iounmap_explicit) are
> low level
s/it's/its/ . Or "the", even.
> + * When CONFIG_PPC_INDIRECT_IO is set, we use the generic iomap
> implementation
> + * which needs some additional definitions here. They basically
> allow PIO
> + * space overall to be 1Gb. This will work as long as we never try
> to use
> + * iomap to map MMIO below 1Gb which should be fine on ppc64
> + */
1GB, not 1Gb.
> +#define HAVE_ARCH_PIO_SIZE 1
> +#define PIO_OFFSET 0x00000000UL
> +#define PIO_MASK 0x3fffffffUL
> +#define PIO_RESERVED 0x40000000UL
Segher
More information about the Linuxppc-dev
mailing list