[PATCH 4/10 v2] Guard L3CR references with CPU_FTR_L3CR.

Benjamin Herrenschmidt benh at kernel.crashing.org
Sat Jun 10 08:07:50 EST 2006


On Fri, 2006-06-09 at 11:00 -0500, Jon Loeliger wrote:
> So, like, the other day Benjamin Herrenschmidt mumbled:
> > On Thu, 2006-06-08 at 16:58 -0500, Jon Loeliger wrote:
> > > Signed-off-by: Jon Loeliger <jdl at freescale.com>
> > 
> > Beware about this one... the CPU setup code might run before the feature
> > fixup in the future...
> > ...
> > or go read the feature bit directly in the structure
> > rather than relying on the fixup mecanism.
> 
> OK.
> 
> > you should probably do a separate setup function for your core
> 
> Truth be told, this is a pretty generic fix for other
> parts as well. If I recall correctly, 7447, 7448, 7448A and 7450
> as well as the new 8641 now.
> 
> But I can certainly introduce a new setup function here
> if you think that is the right thing to do.  No problem.

No, go for the generic fix.

Ben.





More information about the Linuxppc-dev mailing list