[PATCH 1/10] Add the mpc8641 hpcn Kconfig and Makefiles.

[Jon Loeliger]

On Wed, 2006-06-07 at 23:44, Kumar Gala wrote:
> On Jun 7, 2006, at 5:34 PM, Jon Loeliger wrote:


> >  config PPC_I8259
> >  	bool
> > +	default y if PPC_86xx
> >  	default n
> 
> This dependancy seems too generic, shouldn't it be based on some  
> board (its not like 86xx actually has an i8259 in it).

> > +# Makefile for the PowerPC 86xx linux kernel.
> > +#
> > +
> > +obj-$(CONFIG_PPC_86xx)		+= mpc86xx_hpcn.o misc.o
> 
> Seems like mpc86xx_hpcn.o is board specific code and should move down  
> one line.

> > +
> > +config I8259_LEVEL_TRIGGER
> > +	bool
> > +	depends on MPC8641
> > +	default y
> 
> again, seems like it should depend on a board & not MPC8641

OK, I'll fix all of those.


> > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> > index d6d4494..fbeae82 100644
> > --- a/drivers/i2c/busses/Kconfig
> > +++ b/drivers/i2c/busses/Kconfig
> > @@ -252,12 +252,12 @@ config I2C_POWERMAC
> >  
> should probably separate this out into its own patch for the I2C  
> maintainer.

Ah, OK.  Who is that then?

Thanks,
jdl