[Alsa-devel] [RFC 3/8] snd-aoa: add soundbus

[Johannes Berg]

On Fri, 2006-06-02 at 15:53 +0200, Takashi Iwai wrote:
> > +		int l;
> > +		length += sprintf (buf, "%s\n", compat);
> > +		buf += length;
> 
> This seems wrong.  The above should be

Heh, no idea where I copied that from but I sure didn't write it myself.
Should be more careful next time I guess :)

> > +	if (strlen(sdev->modalias)) {
> > +		length = snprintf (buf, 34, "%s\n", sdev->modalias);
> 
> sizeof(sdev->modalias) + 2?  But still strange if modalias has no
> nul-end.

Hm, how would I handle that if modalias has no nul?

johannes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 793 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20060602/d572099c/attachment.pgp>