Fw: therm_adm103x: inquiry

Benjamin Herrenschmidt benh at kernel.crashing.org
Fri Jan 13 21:35:36 EST 2006


On Fri, 2006-01-13 at 20:07 +1100, Paul Mackerras wrote:
> Cedric Pradalier writes:
> 
> > As far as I can see, this module seems mature enough for
> > inclusion in official kernel.
> > 
> > A tested patch against 2.6.14 is available at:
> > http://cedric.pradalier.free.fr/ibook2/adm103x-2.6.14.diff.gz
> > 
> > I've not tested it yet for 2.6.15. 
> > 
> > Some details, from the link site above:
> > 
> > The module provides and sysfs access to the adm103x fan
> > control parameters. For instance
> > 
> > 	  #cat /sys/device/temperatures/info? 
> > 	  T:51°C S:56°C R:10°C  <-- sensor 0
> > 	  T:48°C S:76°C R:10°C  <-- sensor 1
> 
> I think we should remove the degree symbol, since it is neither ASCII
> nor UTF-8, and it is unnecessary.  Apart from that it sounds OK; we
> would have to see the code before deciding whether to include it.

Cedric, you should post the patch directly inline with the mail, with
the proper description and Signed-off-by line.

Ben.





More information about the Linuxppc-dev mailing list