[PATCH] powerpc: consolidate mpc83xx platform files

Kumar Gala galak at kernel.crashing.org
Wed Dec 13 05:03:56 EST 2006


On Dec 12, 2006, at 11:36 AM, Kim Phillips wrote:

> Eliminate code redundancy.  mpc83[246]x_{mds,itx,sys,pb} files merged
> into a single setup.c.  machine definitions moved to machdefs.c with
> corresponding probe fns.  This patch also utilizes  
> of_platform_bus_probe()
> in lieu of manually calling of_platform_device_create for each  
> ucc_geth device.
>
> Signed-off-by: Kim Phillips <kim.phillips at freescale.com>
> ---
>
>  arch/powerpc/kernel/of_platform.c         |    1 +
>  arch/powerpc/platforms/83xx/Makefile      |    6 +-
>  arch/powerpc/platforms/83xx/machdefs.c    |  126 +++++++++++++++
>  arch/powerpc/platforms/83xx/mpc832x_mds.c |  232  
> ----------------------------
>  arch/powerpc/platforms/83xx/mpc832x_mds.h |   19 ---
>  arch/powerpc/platforms/83xx/mpc834x_itx.c |  121 ---------------
>  arch/powerpc/platforms/83xx/mpc834x_itx.h |   23 ---
>  arch/powerpc/platforms/83xx/mpc834x_sys.c |  140 -----------------
>  arch/powerpc/platforms/83xx/mpc834x_sys.h |   23 ---
>  arch/powerpc/platforms/83xx/mpc8360e_pb.c |  236  
> -----------------------------
>  arch/powerpc/platforms/83xx/mpc83xx.h     |    2 +
>  arch/powerpc/platforms/83xx/setup.c       |  188 ++++++++++++++++++ 
> +++++
>  12 files changed, 318 insertions(+), 799 deletions(-)

We should split machdefs into <BOARD>.c and then fixup the Kconfig to  
you can build all of them together?  I think this would be more clear  
and makes for good examples on how a custom board port should go.

- k





More information about the Linuxppc-dev mailing list