[PATCH]: powerpc/pseries: Print PCI slot location code on failure

Paul Mackerras paulus at samba.org
Sat Apr 29 18:00:11 EST 2006


Linas Vepstas writes:

> +		location = (char *) get_property(event->dn, "ibm,loc-code", NULL);
> +		printk(KERN_ERR "EEH: Error: Cannot find partition endpoint "
> +		                "for location=%s pci addr=%s\n",
> +		        location, pci_name(event->dev));

If location is NULL, printk will fortunately save us from a null
pointer dereference; still, it might be nice to have the message say
"location=unknown" or something rather than "location=<NULL>".

Paul.



More information about the Linuxppc-dev mailing list