MV64x60 watchdog timer driver updates

Geert Uytterhoeven geert at linux-m68k.org
Sat Oct 1 01:18:22 EST 2005


On Fri, 30 Sep 2005, Corey Minyard wrote:
> Mark A. Greer wrote:
> > On Thu, Sep 29, 2005 at 01:32:21PM -0500, Corey Minyard wrote:
> > > James looked at an earlier version and said it was ok, and suggested
> > > a few changes.  This has been tested against 2.6.14-rc2 on a Katana.
> > > 
> > > Note that the bus_clk value from the platform information seems to
> > > be in MHZ, but the actual frequency is generally 133,333,333, not
> > > 133,000,000.  I don't think the inaccuracy matters here, but it seems
> > > a little odd.
> > >    
> > 
> > Yes, it makes more sense to me to pass the actual frequency and not do
> > the '* 1000000'.
> >  
> The only trouble is if  you go over 4GHZ...  Maybe it should be in KHZ instead
> of MHZ?  or 64-bits?  Or maybe we don't worry about >4GHZ busses?
> 
> Also, how would one go about changing this?  Would you need something like:
> 
> if (bus_clk < 1000)
>  bus_clk *= 1000000
> 
> for backwards compatability?

Hey, don't touch the i2c! ;-)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds



More information about the Linuxppc-dev mailing list