[PATCH] ppc32: Fix alignment exception checking on load/store multiple instructions

Kumar Gala kumar.gala at freescale.com
Wed Apr 13 01:06:19 EST 2005


On Apr 12, 2005, at 9:46 AM, Dan Malek wrote:

>
>
> On Apr 12, 2005, at 2:03 AM, Kumar Gala wrote:
>
> > The handling of misaligned load/store multiplies did not check to see
> > if
>  > the address were ok to access before __{get,put}_user().
>
> I think we should also take the opportunity to fix up the lawrx
> case and look for other reserved/conditional instructions
>  that may slip through.  Since these are atomic operations, we
> can't emulate them.  According to the PEM, an alignment fault
> on these is a fatal programming error.

When you say "fix up" I assume you mean lwarx should return 0.  It 
appears that stwcx. is already doing that.  Can't think of any other 
cases that need fixing.

- kumar




More information about the Linuxppc-dev mailing list