trini at kernel.crashing.org
Fri Nov 30 10:18:53 EST 2001
On Fri, Nov 30, 2001 at 10:12:33AM +1100, Keith Owens wrote:
> On Thu, 29 Nov 2001 15:46:10 -0700,
> Tom Rini <trini at kernel.crashing.org> wrote:
> >On Fri, Nov 30, 2001 at 09:38:36AM +1100, Keith Owens wrote:
> >> Tom Rini <trini at kernel.crashing.org> wrote:
> >> >and all platforms need a
> >> >platform/platform_serial.h file for serial to work with this scheme?
> >> No, an empty one is automatically generated if necessary.
> >So yes, for CONFIG_SERIAL to work, the file needs to exist. Which has
> >the downside that at least a handful of platforms will need to cp
> Are the *_serial.h files intended as extensions for asm-ppc/serial.h or
> as complete replacements for it?
They could be <asm/serial.h> yes.
> If they are extensions then adding
> #include <platform_serial.h> to asm-ppc/serial.h is enough. If they are
> complete replacements then the code is a little harder, but not much.
> *.c files include only <asm/serial.h>. In platform *_serial.h files,
> #define REPLACES_PPC_SERIAL_H. In asm-ppc/serial.h,
> #include <platform_serial.h>
> #ifndef REPLACES_PPC_SERIAL_H
> ... default ppc serial definitions
That would probably work best, yes.
Tom Rini (TR1265)
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
More information about the Linuxppc-dev