[PATCH] Fixups for Longtrail (2.4.14-pre7)

Paul Mackerras paulus at samba.org
Mon Nov 5 12:01:36 EST 2001

Tom Rini writes:

> Hey all.  I pulled out my Longtrail to play again, and I found some
> wierd problems.  If I keep the 'default' type cards in it (What I
> _think_ are the original video & ethernet, or at least known-OF-happy
> ones), the box actually works.  But If I throw in a PC video card
> (Matrox Millennium 1 in this case) I get oopses all over the place.  I
> think the problem is that the firmware doesn't go and set all of the
> properties, so lots of strcmp's blow up.  The followig gets me both

Instead of checking node->name everywhere, I would prefer that the
prom.c code makes sure that node->name is never NULL.  That is a
change in one place rather than N, and it will fix the places that you
didn't find as well as the ones you did. :)

The OF standard says that each node should have a name property, so I
think it's reasonable for users of the device tree to assume that
node->name is non-NULL.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

More information about the Linuxppc-dev mailing list