[PATCH net-next mlxsw 2/3] mlxsw: spectrum_span: Support mirror-to-VLAN

Petr Machata petrm at mellanox.com
Tue May 8 20:00:58 AEST 2018


Ido Schimmel <idosch at mellanox.com> writes:

> On Mon, May 07, 2018 at 04:29:34PM +0200, Petr Machata wrote:
>> +static const
>> +struct mlxsw_sp_span_entry_ops mlxsw_sp_span_entry_ops_vlan = {
>> +	.can_handle = is_vlan_dev,
>
> You can't handle any VLAN device, but only a VLAN device whose real
> device is a physical port. Why not check that in can_handle()?

OK.


More information about the Linux-mlxsw mailing list