[PATCH net-next mlxsw 2/3] mlxsw: spectrum_span: Support mirror-to-VLAN

[Ido Schimmel]

On Mon, May 07, 2018 at 04:29:34PM +0200, Petr Machata wrote:
> +static const
> +struct mlxsw_sp_span_entry_ops mlxsw_sp_span_entry_ops_vlan = {
> +	.can_handle = is_vlan_dev,

You can't handle any VLAN device, but only a VLAN device whose real
device is a physical port. Why not check that in can_handle()?

> +	.parms = mlxsw_sp_span_entry_vlan_parms,
> +	.configure = mlxsw_sp_span_entry_vlan_configure,
> +	.deconfigure = mlxsw_sp_span_entry_vlan_deconfigure,
> +};