[PATCH] erofs-utils: lib: fix QPL job leak on early error paths in z_erofs_decompress_qpl() After z_erofs_qpl_get_job() succeeds, two early-return error paths bypass z_erofs_qpl_put_job(), leaking the QPL job handle: - Line 200: return -EFSCORRUPTED (when inputmargin >= inputsize) - Line 205: return -ENOMEM (when malloc fails for decodedskip buffer) Fix by replacing the bare returns with goto out_inflate_end, which already handles both z_erofs_qpl_put_job() and free(buff).

[Shubham Vishwakarma]

 Hi Gao,

I understand the concern, but I want to be honest: if I had used AI to
draft the initial submission, it likely would have been sent without those
formatting errors.

The issues with the invalid email address and the oversized subject line
occurred because I was unfamiliar with sending via the SMTP CLI. I used GPT
to help me configure the CLI tool, which led to the mistakes you saw.

I appreciate the feedback on the patch. If there is still doubt regarding
my work, I will continue to submit more patches to demonstrate my ability.

Thanks,

Shubham Vishwakarma


On Fri, Mar 20, 2026 at 7:11 AM Gao Xiang <hsiangkao at linux.alibaba.com>
wrote:

>
>
> On 2026/3/20 09:37, Gao Xiang wrote:
> >
> >
> > On 2026/3/20 09:16, Ajay Rajera wrote:
> >> Hi Vi-shub,
> >> just a review :
> >> I think the fix looks correct and it is the right approach but the
> >> commit message formatting needs work. The entire description is in the
> >> subject line. Per kernel conventions, the subject should be a short
> >> one-liner, e.g: erofs-utils: lib: fix QPL job leak on early error
> >> paths
> >> The detailed explanation (which error paths leak, why, and how the fix
> >> works) should go in the commit message body, separated from the
> >> subject.
> >>
> >> So you can resend with the subject/body split fixed? so It will look
> more clear.
> >
> > yes, the commit message is in a mess.
>
> BTW, I don't know who is using the email address
> <yifan at pku.edu.cn>, and the recipient doesn't exist.
>
> Here, I want to say, I have to identfy you as another
> AI bot.
>
> Thanks,
> Gao Xiang
>
> >
> > Thanks,
> > Gao Xiang
> >
> >> Thanks, Ajay
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-erofs/attachments/20260320/769a4e13/attachment.htm>